<feed xmlns='http://www.w3.org/2005/Atom'>
<title>extra-cmake-modules.git, branch v5.51.0-rc1</title>
<subtitle>hurd extra-cmake-modules.git</subtitle>
<link rel='alternate' type='text/html' href='https://dynamicmalloc.com/cgit/extra-cmake-modules.git/'/>
<entry>
<title>Compile python bindings with the same sip flags used by PyQt</title>
<updated>2018-09-30T20:46:18+00:00</updated>
<author>
<name>Antonio Rojas</name>
<email>arojas@archlinux.org</email>
</author>
<published>2018-09-30T20:46:18+00:00</published>
<link rel='alternate' type='text/html' href='https://dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=05bd97492704029647d442d0f83acb9e6436ed53'/>
<id>05bd97492704029647d442d0f83acb9e6436ed53</id>
<content type='text'>
PyQt&gt;=5.11 is compiled with the 'PyQt5.sip' sipname by default. This causes a sipname mismatch with KF5 bindings and prevents them from loading:

To fix this, we compile KF5 bindings using the same sip flags (name and tags) that PyQt was compiled with. This ensures that we always use the correct sip name. We also stop setting the sip tags in FindPythonModuleGeneration.cmake to avoid duplication, and remove a (seemingly) unnecessary check for the Qt version that was forcing PyQt to be rebuilt for every patch Qt update.

Differential Revision: https://phabricator.kde.org/D15091
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
PyQt&gt;=5.11 is compiled with the 'PyQt5.sip' sipname by default. This causes a sipname mismatch with KF5 bindings and prevents them from loading:

To fix this, we compile KF5 bindings using the same sip flags (name and tags) that PyQt was compiled with. This ensures that we always use the correct sip name. We also stop setting the sip tags in FindPythonModuleGeneration.cmake to avoid duplication, and remove a (seemingly) unnecessary check for the Qt version that was forcing PyQt to be rebuilt for every patch Qt update.

Differential Revision: https://phabricator.kde.org/D15091
</pre>
</div>
</content>
</entry>
<entry>
<title>Android: Allow passing a relative path as the apk dir</title>
<updated>2018-09-29T00:38:32+00:00</updated>
<author>
<name>Aleix Pol</name>
<email>aleixpol@kde.org</email>
</author>
<published>2018-09-28T13:50:31+00:00</published>
<link rel='alternate' type='text/html' href='https://dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=453ba4fee3126648e8ba4cadbef13207e02b1461'/>
<id>453ba4fee3126648e8ba4cadbef13207e02b1461</id>
<content type='text'>
Summary:
This way the project can generate automatically its own manifest file.
GCompris is using it to set the version.

Test Plan: Built GCompris without a warning saying the apkdir isn't found

Reviewers: #frameworks, #gcompris, jjazeix

Reviewed By: #gcompris, jjazeix

Subscribers: jjazeix, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D15643
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Summary:
This way the project can generate automatically its own manifest file.
GCompris is using it to set the version.

Test Plan: Built GCompris without a warning saying the apkdir isn't found

Reviewers: #frameworks, #gcompris, jjazeix

Reviewed By: #gcompris, jjazeix

Subscribers: jjazeix, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D15643
</pre>
</div>
</content>
</entry>
<entry>
<title>Android: Properly offer a fallback to applications that don't have a manifest</title>
<updated>2018-09-27T12:52:54+00:00</updated>
<author>
<name>Aleix Pol</name>
<email>aleixpol@kde.org</email>
</author>
<published>2018-09-27T12:52:54+00:00</published>
<link rel='alternate' type='text/html' href='https://dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=88da70365026ec218e03f6bdaf9803bddd21878c'/>
<id>88da70365026ec218e03f6bdaf9803bddd21878c</id>
<content type='text'>
The variable name was wrong, not much to see here.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The variable name was wrong, not much to see here.
</pre>
</div>
</content>
</entry>
<entry>
<title>l10n: Fix matching digits in the repository name</title>
<updated>2018-09-24T11:27:30+00:00</updated>
<author>
<name>Aleix Pol</name>
<email>aleixpol@kde.org</email>
</author>
<published>2018-09-24T11:27:30+00:00</published>
<link rel='alternate' type='text/html' href='https://dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=efb27e9188c4e0dddac62acdcc03901d656537b8'/>
<id>efb27e9188c4e0dddac62acdcc03901d656537b8</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Android: Make sure Qm translations get loaded</title>
<updated>2018-09-24T10:57:26+00:00</updated>
<author>
<name>Aleix Pol</name>
<email>aleixpol@kde.org</email>
</author>
<published>2018-09-24T10:57:15+00:00</published>
<link rel='alternate' type='text/html' href='https://dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=0d961ecbdf176fd4fe91c19b5479195e87ec5899'/>
<id>0d961ecbdf176fd4fe91c19b5479195e87ec5899</id>
<content type='text'>
Summary: Use a similar strategy as D14528 to find qm files.

Test Plan: Analitza parts of KAlgebra are translated too.

Reviewers: #frameworks, aacid

Reviewed By: aacid

Subscribers: svuorela, aacid, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D14529
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Summary: Use a similar strategy as D14528 to find qm files.

Test Plan: Analitza parts of KAlgebra are translated too.

Reviewers: #frameworks, aacid

Reviewed By: aacid

Subscribers: svuorela, aacid, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D14529
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix Android builds using cmake 3.12.1</title>
<updated>2018-09-24T10:56:47+00:00</updated>
<author>
<name>Aleix Pol</name>
<email>aleixpol@kde.org</email>
</author>
<published>2018-09-24T10:55:30+00:00</published>
<link rel='alternate' type='text/html' href='https://dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=20e619af331f0a7e7632a351eb67c62e0209910a'/>
<id>20e619af331f0a7e7632a351eb67c62e0209910a</id>
<content type='text'>
Summary: Only extract the the stl shared object without the rest of libraries.

Test Plan: Built gcompris

Reviewers: #frameworks, vkrause

Reviewed By: vkrause

Subscribers: kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D15685
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Summary: Only extract the the stl shared object without the rest of libraries.

Test Plan: Built gcompris

Reviewers: #frameworks, vkrause

Reviewed By: vkrause

Subscribers: kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D15685
</pre>
</div>
</content>
</entry>
<entry>
<title>Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags</title>
<updated>2018-09-22T17:07:34+00:00</updated>
<author>
<name>Laurent Montel</name>
<email>montel@kde.org</email>
</author>
<published>2018-09-17T05:37:55+00:00</published>
<link rel='alternate' type='text/html' href='https://dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=9b528012703ae584e80a4954df153091a1443be9'/>
<id>9b528012703ae584e80a4954df153091a1443be9</id>
<content type='text'>
Summary: Use QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default flags

Reviewers: dfaure

Reviewed By: dfaure

Subscribers: kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D15566
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Summary: Use QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default flags

Reviewers: dfaure

Reviewed By: dfaure

Subscribers: kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D15566
</pre>
</div>
</content>
</entry>
<entry>
<title>Python bindings: use cmake_parse_arguments, fix documentation</title>
<updated>2018-09-20T12:22:54+00:00</updated>
<author>
<name>Stefan Brüns</name>
<email>stefan.bruens@rwth-aachen.de</email>
</author>
<published>2018-09-16T19:46:01+00:00</published>
<link rel='alternate' type='text/html' href='https://dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=b322901ca22f9c944b07eebbdcb4d45230d74084'/>
<id>b322901ca22f9c944b07eebbdcb4d45230d74084</id>
<content type='text'>
Summary:
Use of positional arguments is error prone, as e.g. switching order
of NAMESPACE and MODULENAME wont have the desired effect, as
the keywords are ignored for the first three arguments.

Parse all arguments with cmake_parse_arguments, and fix the documentation
(list supported arguments) and example (add TARGET keyword).

Test Plan: build bindings

Reviewers: #frameworks, dfaure

Reviewed By: dfaure

Subscribers: kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D15559
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Summary:
Use of positional arguments is error prone, as e.g. switching order
of NAMESPACE and MODULENAME wont have the desired effect, as
the keywords are ignored for the first three arguments.

Parse all arguments with cmake_parse_arguments, and fix the documentation
(list supported arguments) and example (add TARGET keyword).

Test Plan: build bindings

Reviewers: #frameworks, dfaure

Reviewed By: dfaure

Subscribers: kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D15559
</pre>
</div>
</content>
</entry>
<entry>
<title>Bindings: Correct handling of sources containing utf-8</title>
<updated>2018-09-14T12:45:41+00:00</updated>
<author>
<name>Stefan Brüns</name>
<email>stefan.bruens@rwth-aachen.de</email>
</author>
<published>2018-08-19T00:32:14+00:00</published>
<link rel='alternate' type='text/html' href='https://dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=28da9e614f663210f4e5e0790b56055ce517bf38'/>
<id>28da9e614f663210f4e5e0790b56055ce517bf38</id>
<content type='text'>
Summary:
Depending on the locale, python3 may try to decode the source as ASCII
when the file is opened in text mode. This will fail as soon as the
code contains utf-8, e.g. (c) symbols.

While it is possible to specify the encoding when reading the file,
this is bad for several reasons:
- only a very small part of the source is processed via _read_source,
  no need to decode the complete source and store it as string objects
- the clang Cursor.extent.{start,end}.column refers to bytes, not
  multibyte characters.

While python2 processes utf-8 containing sources without error messages,
wrong extent borders are also an issue.

The practical impact is low, as the issue only manifests if there is a
multibyte character in front of *and* on the same line as the read token.

Test Plan:
Python3: Build any bindings which contains sources with non-ASCII codepoints,
e.g. kcoreaddons. Unpatched version fails when using e.g. LANG=C.
Python2: Both versions generate sources successfully.

Bytes vs characters test:
```
#define Q_SLOTS
class foo {
/* a */ public Q_SLOTS:
/* ä */ public Q_SLOTS:
};
```
`sip_generator.py --flags "" /usr/lib64/libclang.so Qt5Ruleset.py  test.h out.sip`
Obviously, both lines should result in the same code, the unfixed version generates `public Q_SLOTS:` vs `public:`.

Reviewers: #frameworks, lbeltrame

Reviewed By: lbeltrame

Subscribers: lbeltrame, bcooksley, jtamate, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D15068
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Summary:
Depending on the locale, python3 may try to decode the source as ASCII
when the file is opened in text mode. This will fail as soon as the
code contains utf-8, e.g. (c) symbols.

While it is possible to specify the encoding when reading the file,
this is bad for several reasons:
- only a very small part of the source is processed via _read_source,
  no need to decode the complete source and store it as string objects
- the clang Cursor.extent.{start,end}.column refers to bytes, not
  multibyte characters.

While python2 processes utf-8 containing sources without error messages,
wrong extent borders are also an issue.

The practical impact is low, as the issue only manifests if there is a
multibyte character in front of *and* on the same line as the read token.

Test Plan:
Python3: Build any bindings which contains sources with non-ASCII codepoints,
e.g. kcoreaddons. Unpatched version fails when using e.g. LANG=C.
Python2: Both versions generate sources successfully.

Bytes vs characters test:
```
#define Q_SLOTS
class foo {
/* a */ public Q_SLOTS:
/* ä */ public Q_SLOTS:
};
```
`sip_generator.py --flags "" /usr/lib64/libclang.so Qt5Ruleset.py  test.h out.sip`
Obviously, both lines should result in the same code, the unfixed version generates `public Q_SLOTS:` vs `public:`.

Reviewers: #frameworks, lbeltrame

Reviewed By: lbeltrame

Subscribers: lbeltrame, bcooksley, jtamate, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D15068
</pre>
</div>
</content>
</entry>
<entry>
<title>autotests: actually iterate over the list, rather than checking item 0 all the time</title>
<updated>2018-09-12T19:03:34+00:00</updated>
<author>
<name>David Faure</name>
<email>faure@kde.org</email>
</author>
<published>2018-09-12T19:03:34+00:00</published>
<link rel='alternate' type='text/html' href='https://dynamicmalloc.com/cgit/extra-cmake-modules.git/commit/?id=5ecea2ff63c36afc2dad77f33899bdf9eb260e51'/>
<id>5ecea2ff63c36afc2dad77f33899bdf9eb260e51</id>
<content type='text'>
Found while grepping for examples of foreach(... RANGE ...) for my
cmake training material ;-)
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Found while grepping for examples of foreach(... RANGE ...) for my
cmake training material ;-)
</pre>
</div>
</content>
</entry>
</feed>
