extra-cmake-modules.git, branch v5.59.0-rc1

Create specific directory for Qt logging categories file

2019-05-31T14:55:38+00:00

Summary: kdebugsettings categories files

Reviewers: dfaure, cgiboudeaux

Reviewed By: cgiboudeaux

Subscribers: kossebau, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D21313

Don't enable QT_STRICT_ITERATORS on Windows.

2019-05-22T07:49:48+00:00

Summary:
Strict iterators can't be used on Windows, they lead to a link error
when application code iterates over a QVector for instance, unless
Qt itself was also built with strict iterators.
See example at https://bugreports.qt.io/browse/AUTOSUITE-946

Technically this would be fine for mingw, but not for MSVC neither
clang-cl (which also uses the MSVC ABI). I think it's fine to just
disable it for all Windows compilers, since any iterators misuse
will be detected on Unix anyway.

Test Plan: None, I'm relying on Volker's findings.

Reviewers: vkrause, dvratil

Reviewed By: dvratil

Subscribers: apol, kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D21314

GIT_SILENT Upgrade ECM version to 5.59.0.

2019-05-15T08:26:48+00:00

Bug fix: find c++ stl using regex

2019-04-17T15:56:52+00:00

Summary:
Find C++ shared lib path using regex. This change makes finding path
independent of the order in which it was added by cmake.

Reviewers: apol

Reviewed By: apol

Subscribers: kde-buildsystem, kde-frameworks-devel

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D20558

Detect duplicate ANDROID_EXTRA_LIBS and minor bug fix

2019-04-15T00:13:22+00:00

Summary:
Don't include same dependency twice, one which was found
from `readelf` in `specifydependencies.cmake` and other in
`ANDROID_EXTRA_LIBS`.

Bug fix: find stl was dependent on the order in which libc++
was added, now it is independent.

Test Plan: * add the same dependency in ANDROID_EXTRA_LIBS

Reviewers: apol, vkrause

Reviewed By: apol

Subscribers: kde-buildsystem, kde-frameworks-devel

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D20509

GIT_SILENT Upgrade ECM version to 5.58.0.

2019-04-13T09:56:57+00:00

Unconditionally enable -DQT_STRICT_ITERATORS, not just in debug mode

2019-04-07T17:00:28+00:00

Summary:
It turns out QT_STRICT_ITERATORS does not introduce any
overhead (they are inlined so everything gets optimized), confirmed by
Dan comparing the produced assembly in Compiler Explorer.

Reviewers: dvratil, mlaurent, aacid

Reviewed By: aacid

Subscribers: aacid, kde-buildsystem, kde-frameworks-devel

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D20349

Re-enable the setting of QT_PLUGIN_PATH, without the strange backslash.

2019-03-31T18:30:16+00:00

Let's see if purpose unittests still work on Windows (which was the
reason this got commented out, kio_file wasn't found anymore).

CCMAIL: bcooksley@kde.org, kfunk@kde.org

ecm_add_wayland_client_protocol: Improve error messages

2019-03-29T12:32:19+00:00

Summary: Instead of passing the data from stdin, pass the path, this way if there's an error wayland-scanner will be able to tell us the file and line where it's failing.

Test Plan: Built kwayland and kwin with it

Reviewers: #kwin, #frameworks, zzag

Reviewed By: #kwin, zzag

Subscribers: kde-frameworks-devel, kde-buildsystem

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D20105

Revert "Take clang-cl into account"

2019-03-23T13:49:37+00:00

This reverts commit 2e1cb0c453f419da134b850052da6c804cae05e0.

This was an accidental push to master, sorry for the noise.