extra-cmake-modules.git/kde-modules, branch v5.33.0-rc1

KDE compiler settings: treat Clang and AppleClang equally

2017-03-19T08:53:58+00:00

https://phabricator.kde.org/D5089

Only register APPLE_* options if(APPLE)

2017-03-05T23:08:14+00:00

Summary: Otherwise the cmake cache has noisy values.

Test Plan: Recreated a project, it's not listed first thing when calling ccmake.

Reviewers: #frameworks, dfaure

Reviewed By: dfaure

Subscribers: #build_system

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D4630

Fix ENABLE_CLAZY on Windows

2017-02-01T13:22:22+00:00

Summary:

Reviewers: smartins, alexmerry, apol

Reviewed By: apol

Subscribers: #windows, #build_system, #frameworks

Tags: #frameworks, #build_system

Differential Revision: https://phabricator.kde.org/D4389

Enable -Wsuggest-override for g++ >= 5.0.0

2017-01-23T19:04:47+00:00

REVIEW: 129724

Pass -fno-operator-names when supported

2017-01-16T07:46:43+00:00

Summary:
Disables alternative tokens for &&, ||, etc.. They're are not supported
by MSVC out of the box, thus using them will limit the portability of
the code. There *are* options to make alternative tokens available under
MSVC [1], but I think we shouldn't promote the usage of them.

From the GCC documentation:
-fno-operator-names: Do not treat the operator name keywords and,
bitand, bitor, compl, not, or and xor as synonyms as keywords.

[1] http://stackoverflow.com/questions/555505/when-were-the-and-and-or-alternative-tokens-introduced-in-c

Reviewers: #frameworks, #buildsystem, ivan

Reviewed By: ivan

Subscribers: rakuco, elvisangelaccio

Differential Revision: https://phabricator.kde.org/D3850

Revert "Enable -Wsuggest-override for g++ >= 5.0.0"

2017-01-03T00:25:51+00:00

This reverts commit d1d637fadd6dad68995d44101250ebbc3307ed0b.

This is far too noisy.

The correct steps for this kind of change are:

* Enable the warning locally
* Take the action recommended by the warning in the code, and push the
  result
* Push the warning on everyone to enforce that the code stays fixed for
  the future

appstreamtest: handle non-installed programs

2016-12-30T07:41:16+00:00

Summary:
If you just built the software without installing it and then run ctest,
this will systematically fail while trying to read install_manifest.txt.
With this patch this case is now handled gracefully, not forcing to
install to have a test suite which fully passes.

Reviewers: #frameworks, apol

Differential Revision: https://phabricator.kde.org/D3860

Enable -Wsuggest-override for g++ >= 5.0.0

2016-12-29T23:48:29+00:00

REVIEW: 129724

Enable colored warnings in ninja's output

2016-12-29T11:18:55+00:00

Summary:
Colored compiler warnings in ninja output only work with the
`-fdiagnostics-color=always` flag.
See https://github.com/ninja-build/ninja/issues/814 for a rationale.

This commit adds such flag in ecm for gcc >= 4.9 and clang >= 3.5,
and only if the CMAKE_GENERATOR is Ninja.

Test Plan: ninja+gcc and ninja+clang now show nice colored compiler warnings.

Reviewers: #frameworks

Differential Revision: https://phabricator.kde.org/D3733

Never use -Wl,--no-undefined on Mac (APPLE).

2016-12-11T18:03:31+00:00

While unusual it is not impossible to use GCC on Macs, esp. not when
using older OS X versions. Intel also makes compilers for Mac, so it may
in fact be better to rewrite the check ((GNU or Clang or Intel) IF NOT
(APPLE or WIN32)).