From 9b0df10c7d1ee449237a6187049408743308a302 Mon Sep 17 00:00:00 2001 From: David Faure Date: Sun, 7 Apr 2019 15:18:52 +0200 Subject: Unconditionally enable -DQT_STRICT_ITERATORS, not just in debug mode Summary: It turns out QT_STRICT_ITERATORS does not introduce any overhead (they are inlined so everything gets optimized), confirmed by Dan comparing the produced assembly in Compiler Explorer. Reviewers: dvratil, mlaurent, aacid Reviewed By: aacid Subscribers: aacid, kde-buildsystem, kde-frameworks-devel Tags: #frameworks, #build_system Differential Revision: https://phabricator.kde.org/D20349 --- kde-modules/KDEFrameworkCompilerSettings.cmake | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/kde-modules/KDEFrameworkCompilerSettings.cmake b/kde-modules/KDEFrameworkCompilerSettings.cmake index 7b62c3e0..d2db5e56 100644 --- a/kde-modules/KDEFrameworkCompilerSettings.cmake +++ b/kde-modules/KDEFrameworkCompilerSettings.cmake @@ -55,12 +55,9 @@ add_definitions(-DQT_NO_CAST_TO_ASCII -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_USE_QSTRINGBUILDER -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT + -DQT_STRICT_ITERATORS ) -if (CMAKE_BUILD_TYPE STREQUAL "Debug") - add_definitions(-DQT_STRICT_ITERATORS) -endif() - if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR CMAKE_CXX_COMPILER_ID MATCHES "Clang") set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -pedantic") endif() -- cgit v1.2.1