From 187d8881a6a0c33f50eb65689aa1dd74a8d107a4 Mon Sep 17 00:00:00 2001 From: "R.J.V. Bertin" Date: Sun, 11 Dec 2016 19:03:31 +0100 Subject: Never use -Wl,--no-undefined on Mac (APPLE). While unusual it is not impossible to use GCC on Macs, esp. not when using older OS X versions. Intel also makes compilers for Mac, so it may in fact be better to rewrite the check ((GNU or Clang or Intel) IF NOT (APPLE or WIN32)). --- kde-modules/KDECompilerSettings.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'kde-modules/KDECompilerSettings.cmake') diff --git a/kde-modules/KDECompilerSettings.cmake b/kde-modules/KDECompilerSettings.cmake index f81b6610..8b458f55 100644 --- a/kde-modules/KDECompilerSettings.cmake +++ b/kde-modules/KDECompilerSettings.cmake @@ -332,7 +332,7 @@ endfunction() # Better diagnostics (warnings, errors) ############################################################ -if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU" OR +if ((CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND NOT APPLE) OR (CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND NOT APPLE) OR (CMAKE_CXX_COMPILER_ID STREQUAL "Intel" AND NOT WIN32)) # Linker warnings should be treated as errors -- cgit v1.2.1