Summary:
the previous description of IncludeGlobals was a bit lackluster. the new
description should make it more obvious what the various flag permutations
achieve.

BUG: 306923

Reviewers: kde-frameworks-devel, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19388

Summary:
In commit 8579ec54 (D13034), the Notify value got introduced in
enum WriteConfigFlag in KConfigBase. When adding this new value,
the value and its documentation (Doxygen format, /**<) got placed
wrongly.
After commit 8579ec54, the documentation for Notify "documents"
the previously existing value Localized, whereas the documentation
for Localized documents Notify.
Simply exchanging the order of the documentation comments fixes
this issue.

Reviewers: broulik, dfaure, davidedmundson

Reviewed By: davidedmundson

Subscribers: kde-frameworks-devel

Tags: documentation, frameworks

Differential Revision: https://phabricator.kde.org/D19320

Summary:
commit 6a18528 introduced escaping of bytes >= 127 to ensure that
KConfig files are valid UTF8.
The simplistic approach with a cutoff results in many escaped bytes
where it is not required. Especially non-western configuration files
would have many escapes.

This commit fixes that by only escaping bytes that are not valid UTF8.

BUG: 403557
FIXED-IN: 5.56

Test Plan: ninja && ninja test

Reviewers: dfaure, arichardson, apol, #frameworks, thiago

Subscribers: rapiteanu, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D19107

Summary:
When /home is a symlink, for instance (as is often the case on FreeBSD),
group deletion would fail because KConfig was comparing non-canonical
paths with canonical-paths:

QDEBUG : KConfigTest::testDelete() Comparing "/home/adridg/.qttest/config/
kconfigtest_subdir/kconfigtest" and "/usr/home/adridg/.qttest/config/
kconfigtest_subdir/kconfigtest"

Test Plan:
mkdir /tmp/derp; ln -s /tmp/derp /tmp/drop
HOME=/tmp/derp bin/kconfigtest testDelete  # Success
HOME=/tmp/drop bin/kconfigtest testDelete  # Fail

Reviewers: adridg, arichardson, apol

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D14927

Summary:
If someone was using them, it'd crash since it was raw-copying the d pointer
so you would end up with a double delete.

This is SIC, but IMHO it's fine, whoever gets a compiler failure has a bug to fix

Reviewers: vkrause

Reviewed By: vkrause

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D18135

Summary:
Bytes from 'Strings' of type GroupString and KeyString should not be
escaped because they are valid UTF-8. Only instances of ValueString
should be escaped.

This fixes the failing test KConfigTest::testEncoding

Test Plan: Ran `ninja test` and found no errors.

Reviewers: dfaure, arichardson, apol, aacid, ngraham

Reviewed By: apol

Subscribers: kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17856

Summary:
UserBase tells me that KDE configuration files are encoded in UTF-8.
https://userbase.kde.org/KDE_System_Administration/Configuration_Files

In practice some *rc files have bytes outside that encoding. In my home directory I found two files that are not valid UTF-8.

I searched with
    find ~/.config/ -name '*rc' -exec file {} +
which gives these exceptions:

akonadiconsolerc: Non-ISO extended-ASCII text, with very long lines
kmail2rc: Non-ISO extended-ASCII text, with very long lines

In kmail2rc, the offending fields are
[AttachmentView]/State
[CollectionFolderView]/HeaderState

Both are QByteArray values saved from QHeaderView::saveState().

In the instance I found, the offending bytes were 0x81 and 0x84.

akonadiconsolerc had way more of these values. All seem related to saving widget state and hence probably QByteArrays.

The written QByteArray values look very strange. The bytes in the non-printable ASCII range are written as \xXX but the values above 127 are written literally.

The encoding is done  by KConfigIniBackend::stringToPrintable. It does not currently escape bytes that are larger than  or equal to 127.

Reviewers: dfaure, arichardson, apol

Reviewed By: apol

Subscribers: apol, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D17651

Notify was changed to 0x08 | Persistent as it implied the other flag
state. However this change was not updated in the test.

Reviewed-by: Kai Uwe Broulik