kconfig.git/src/gui, branch v5.79.0

Fix window positioning regression due to incorrect fallback in fallback

2021-02-10T08:32:56+00:00

We have a fallback string that gets searched for in the KCM, but that
fallback itself should not have a fallback, or else we always use that
second fallback and the window gets positioned incorrectly the first
time it's opened. So let's replace the second fallback with -1.

BUG: 432661
FIXED-IN: 5.79
(cherry picked from commit 97accd14d732f3eda1c25bb58290cb9311040798)

Refactor window geometry save/restore code to be less fragile

2021-02-03T02:39:34+00:00

This commit refactors the code a bit to define the window geometry
strings in one place and uses a common method to read and write them.

This makes future changes much less fragile and fixes a pre-existing bug
that had gone un-noticed which caused window positions to not be saved
on a per-resolution basis in addition to a per-display-arrangement
basis. Old strings are used if available to that people don't lose their
saved position data the first time they upgrade to KF 5.79.

Fix restoring window size when closed while maximized

2021-02-02T14:40:49+00:00

The maximization string was being saved to the config file including
the connected screens, but the code to read it was not, and was also
looking for the old incorrect format. This could have resulted in old
config values being used forever, and the window always being opened
in a maximized state.

BUG: 430521
FIXED-IN: 5.79

Replace KF5_VERSION with KF_VERSION

2021-01-29T21:23:01+00:00

Frameworks will be Frameworks 6 at some point and there is no good reason to have the major version in the variable name.

Given this is purely internal we can to this now, making it a bit more future-proof

GIT_SILENT

NO_CHANGELOG

QString::split(QChar, Qt::SplitBehavior, ...) is already in Qt 5.14

2021-01-14T18:05:03+00:00

NO_CHANGELOG

Remove unused include

2020-12-10T21:58:11+00:00

Use | instead of + for combining keys

2020-12-10T21:07:34+00:00

The latter breaks with Qt6

Fix windows being inappropriately maximized on launch

2020-12-09T18:23:27+00:00

When a window is closed while maximized, we write a special string to
the config file so that it gets restored in its maximized state. But we
don't ever delete that thing when the window is un-maximized and closed
again, causing the window to always be maximized when launched.

BUG: 426813
FIXED-IN: 5.78

Correct format of window maximized string

2020-12-09T03:10:13+00:00

All other resolutions are stored in the form of width x height, but a
silly transposition error had the maximized strong being height x width.
That's fixed now.

Fix window sizing and positioning on Windows

2020-12-07T22:15:28+00:00

The feature to make windows remember their sizes and positions across
screen layouts relied on calling QScreen::name() to identify screens.
Unfortunately this function returns garbage on Windows; see
https://bugreports.qt.io/browse/QTBUG-74317

So on Windows, let's identify displays by serial number as a workaround.

BUG: 429943
FIXED-IN: 5.78