kconfig.git/src/gui, branch v5.81.0-rc1

Optimise string operations a bit

2021-03-05T23:33:45+00:00

- Use QString::arg(Args...) instead of .arg().arg()
- Use QLatin1String for string comparisons, should be faster
- Use QLatin1String::arg() for better readability

- Add the comment dfaure suggested in the MR, to explain why it's '2%'
  then '%1' in a QString().arg().arg()

NO_CHANGELOG

Fix formatting in a couple of places after running clang-format

2021-02-22T19:28:00+00:00

NO_CHANGELOG

Run clang-format on all cpp/h files

2021-02-22T15:38:09+00:00

NO_CHANGELOG

Add a trailing comma to last member in enum

2021-02-22T15:34:03+00:00

GIT_SILENT

Fix window positioning regression due to incorrect fallback in fallback

2021-02-08T18:53:28+00:00

We have a fallback string that gets searched for in the KCM, but that
fallback itself should not have a fallback, or else we always use that
second fallback and the window gets positioned incorrectly the first
time it's opened. So let's replace the second fallback with -1.

BUG: 432661
FIXED-IN: 5.79

Minor code optimisations

2021-02-06T20:11:41+00:00

- Use a global var for a QString that's used many times
- Break up long-all-cap variable names, it makes it harder to read (and
  I've fixed one typo in one of those ALLCAPS)
- Fix some clazy warnings, make global QString objects in unit tests
static (so that the compiler doesn't create symbols for them, it doesn't
matter in a unit test but KF code acts as a reference sometimes that
others copy from, tip from dfaure)
- Add TODO note about changing kconfig_compiler to generate C++ code that
  uses multi-arg QString::arg(QString, QString, QString) instead of
  QString::arg().arg()
- More const; more QString::at() instead of operator[] where appropriate
- Use a ternary where it makes the code more readable (and uses less lines :))

NO_CHANGELOG

Refactor window geometry save/restore code to be less fragile

2021-02-03T02:39:34+00:00

This commit refactors the code a bit to define the window geometry
strings in one place and uses a common method to read and write them.

This makes future changes much less fragile and fixes a pre-existing bug
that had gone un-noticed which caused window positions to not be saved
on a per-resolution basis in addition to a per-display-arrangement
basis. Old strings are used if available to that people don't lose their
saved position data the first time they upgrade to KF 5.79.

Fix restoring window size when closed while maximized

2021-02-02T14:40:49+00:00

The maximization string was being saved to the config file including
the connected screens, but the code to read it was not, and was also
looking for the old incorrect format. This could have resulted in old
config values being used forever, and the window always being opened
in a maximized state.

BUG: 430521
FIXED-IN: 5.79

Replace KF5_VERSION with KF_VERSION

2021-01-29T21:23:01+00:00

Frameworks will be Frameworks 6 at some point and there is no good reason to have the major version in the variable name.

Given this is purely internal we can to this now, making it a bit more future-proof

GIT_SILENT

NO_CHANGELOG

QString::split(QChar, Qt::SplitBehavior, ...) is already in Qt 5.14

2021-01-14T18:05:03+00:00

NO_CHANGELOG