diff options
| author | Imran Tatriev <itatriev@gmail.com> | 2015-12-23 20:57:57 +0600 |
|---|---|---|
| committer | Imran Tatriev <itatriev@gmail.com> | 2015-12-23 20:57:57 +0600 |
| commit | 74d30c02373383748219318372907539d8259250 (patch) | |
| tree | 21e20ecb317dba98a073429796a3459b6faea133 /src/kconf_update | |
| parent | 48d8290107091cb324633895f287ca47f70bb972 (diff) | |
| download | kconfig-74d30c02373383748219318372907539d8259250.tar.gz kconfig-74d30c02373383748219318372907539d8259250.tar.bz2 | |
Fix some Clazy warnings
Diffstat (limited to 'src/kconf_update')
| -rw-r--r-- | src/kconf_update/kconf_update.cpp | 4 | ||||
| -rw-r--r-- | src/kconf_update/kconfigutils.cpp | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/src/kconf_update/kconf_update.cpp b/src/kconf_update/kconf_update.cpp index 9567c2d6..5108fb2e 100644 --- a/src/kconf_update/kconf_update.cpp +++ b/src/kconf_update/kconf_update.cpp @@ -131,7 +131,7 @@ KonfUpdate::KonfUpdate(QCommandLineParser *parser) return; } updateFiles.append(file); - } else if (parser->positionalArguments().count()) { + } else if (!parser->positionalArguments().isEmpty()) { updateFiles += parser->positionalArguments(); } else { if (cg.readEntry("autoUpdateDisabled", false)) { @@ -520,7 +520,7 @@ void KonfUpdate::gotFile(const QString &_file) if (!m_oldFile.isEmpty()) { // if File= is specified, it doesn't exist, is empty or contains only kconf_update's [$Version] group, skip if (m_oldConfig1 != Q_NULLPTR && (m_oldConfig1->groupList().isEmpty() - || (m_oldConfig1->groupList().count() == 1 && m_oldConfig1->groupList().first() == QLatin1String("$Version")))) { + || (m_oldConfig1->groupList().count() == 1 && m_oldConfig1->groupList().at(0) == QLatin1String("$Version")))) { log() << m_currentFilename << ": File '" << m_oldFile << "' does not exist or empty, skipping" << endl; m_skipFile = true; } diff --git a/src/kconf_update/kconfigutils.cpp b/src/kconf_update/kconfigutils.cpp index 12b07499..02b3f0a9 100644 --- a/src/kconf_update/kconfigutils.cpp +++ b/src/kconf_update/kconfigutils.cpp @@ -96,7 +96,7 @@ QString unescapeString(const QString &src, bool *ok, QString *error) dst += '\\'; } else if (ch == 'x') { if (pos + 2 < length) { - char value = src.mid(pos + 1, 2).toInt(ok, 16); + char value = src.midRef(pos + 1, 2).toInt(ok, 16); if (*ok) { dst += QChar::fromLatin1(value); pos += 2; |