Optimise string operations a bit

- Use QString::arg(Args...) instead of .arg().arg()
- Use QLatin1String for string comparisons, should be faster
- Use QLatin1String::arg() for better readability

- Add the comment dfaure suggested in the MR, to explain why it's '2%'
  then '%1' in a QString().arg().arg()

NO_CHANGELOG

2 files changed, 13 insertions, 11 deletions

diff --git a/src/kreadconfig/kreadconfig.cpp b/src/kreadconfig/kreadconfig.cpp
index 444f3bde..f0fb3518 100644
--- a/src/kreadconfig/kreadconfig.cpp
+++ b/src/kreadconfig/kreadconfig.cpp
@@ -74,21 +74,23 @@ int main(int argc, char **argv)
         configMustDeleted = true;
     }
     KConfigGroup cfgGroup = konfig->group(QString());
-    for (const QString &grp : groups)
+    for (const QString &grp : groups) {
         cfgGroup = cfgGroup.group(grp);
-    if (type == QStringLiteral("bool")) {
+    }
+
+    if (type == QLatin1String{"bool"}) {
         dflt = dflt.toLower();
-        bool def = (dflt == QStringLiteral("true") || dflt == QStringLiteral("on") || dflt == QStringLiteral("yes") || dflt == QStringLiteral("1"));
+        bool def = (dflt == QLatin1String{"true"} || dflt == QLatin1String{"on"} || dflt == QLatin1String{"yes"} || dflt == QLatin1String{"1"});
         bool retValue = !cfgGroup.readEntry(key, def);
         if (configMustDeleted)
             delete konfig;
         return retValue;
-    } else if ((type == QStringLiteral("num")) || (type == QStringLiteral("int"))) {
+    } else if (type == QLatin1String{"num"} || type == QLatin1String{"int"}) {
         int retValue = cfgGroup.readEntry(key, dflt.toInt());
         if (configMustDeleted)
             delete konfig;
         return retValue;
-    } else if (type == QStringLiteral("path")) {
+    } else if (type == QLatin1String{"path"}) {
         fprintf(stdout, "%s\n", cfgGroup.readPathEntry(key, dflt).toLocal8Bit().data());
         if (configMustDeleted)
             delete konfig;
diff --git a/src/kreadconfig/kwriteconfig.cpp b/src/kreadconfig/kwriteconfig.cpp
index a8a1ee4e..67d9637e 100644
--- a/src/kreadconfig/kwriteconfig.cpp
+++ b/src/kreadconfig/kwriteconfig.cpp
@@ -69,15 +69,15 @@ int main(int argc, char **argv)
 
     if (del) {
         cfgGroup.deleteEntry(key);
-    } else if (type == QStringLiteral("bool")) {
+    } else if (type == QLatin1String{"bool"}) {
         // For symmetry with kreadconfig we accept a wider range of values as true than Qt
         /* clang-format off */
-        bool boolvalue = value == QStringLiteral("true")
-                         || value == QStringLiteral("on")
-                         || value == QStringLiteral("yes")
-                         || value == QStringLiteral("1"); /* clang-format on */
+        bool boolvalue = value == QLatin1String{"true"}
+                         || value == QLatin1String{"on"}
+                         || value == QLatin1String{"yes"}
+                         || value == QLatin1String{"1"}; /* clang-format on */
         cfgGroup.writeEntry(key, boolvalue);
-    } else if (type == QStringLiteral("path")) {
+    } else if (type == QLatin1String{"path"}) {
         cfgGroup.writePathEntry(key, value);
     } else {
         cfgGroup.writeEntry(key, value);