| Age | Commit message (Collapse) | Author |
|---|
|
Some tests are testing underlying components, these should be tested
before testing the components that depend on them.
REVIEW: 118680
|
|
|
|
The underlying KConfig used QLocale::name() for getting the locale
aware part. But this returns "de_DE" while the desktop files store
"de".
In addition it constructs a QLocale object instead of using the
system locale. This has the advantage that the usage of
QLocale::setDafault() gets honored by KConfig.
REVIEW: 118564
|
|
- use Q_NULLPTR instead of 0 or NULL
- simplify some foreach loops
- use QStringLiteral in a few places
- added a few consts
REVIEW: 118666
|
|
The underlying KConfig used QLocale::name() for getting the locale
aware part. But this returns "de_DE" while the desktop files store
"de".
In addition it constructs a QLocale object instead of using the
system locale. This has the advantage that the usage of
QLocale::setDafault() gets honored by KConfig.
REVIEW: 118564
|
|
kreadconfig only needs to print help when a key is not given or when extra
text is on the end of the command line.
BUG: 335806
|
|
|
|
|
|
This should have been part of 8b88eaee.
REVIEW: 118339
|
|
According to http://qt-project.org/doc/qt-5/qvariant.html#type the
return value of QVariant::type() should be interpreted as a
QMetaType::Type.
This also silences the compile-time warnings about 38 not being a member
of QVariant::Type.
REVIEW: 118332
|
|
Simplify KConfigGroup::readEntry/writeEntry.
KConfigGroup::readCheck/writeCheck caused some compilers to complain
since they were private functions that were being reimplemented outside
the class definition.
Updated KCONFIGGROUP_DECLARE_ENUM_QOBJECT/
deprecated global functions created in KDE4 times.
|
|
Previous code said if we found an executable in kconf_update_bin
try to find a different executable in the normal path
Reviewed-by: Rohan Garg
|
|
/home/scripty/prod/git-unstable/frameworks_kconfig/src/core/bufferfragment_p.h:37: Ignoring definition of undeclared qualified class
/home/scripty/prod/git-unstable/frameworks_kconfig/src/core/bufferfragment_p.h:37: Ignoring definition of undeclared qualified class
|
|
|
|
This reverts commit 88c9a9664e99b639df4cde2be22dbe44df228879.
|
|
|
|
Open a new QFile for reading after calling close() on the temp file
|
|
|
|
We get a CMake warning for reading the LOCATION property, but I don't see
how else to do it (generator expressions don't seem to work)
|
|
This allows removing some custom WIN32 API code and is also nicer than
directly calling system()
|
|
The MOC files for generated output from kconfig_compiler are not automatically
generated. Re-add the code that does this, fixing the build.
I'm assuming this isn't an issue on Windows, as I don't have any machines to
test on. Please let me know if this isn't the case.
CC: arichardson.kde@gmail.com
|
|
We have to generate the files in the same directory as the test executables
otherwise QFINDTESTDATA will fail
|
|
now use QCoreApplication::applicationName() + "rc" as the config file name
instead of hardcoding the named
|
|
This also fixes running 'nmake test' on Windows.
|
|
This reverts commit 625e124898afad04ab5c3939b1b129b6014046cd.
Let's take the time to think about a better solution, possibly.
|
|
|
|
Make sure I see any review requests by default.
|
|
Only KSharedConfig::openConfig() and KConfig default constructor are affected.
KConfig("kdeglobals"), for instance, points to ~/.config so that it can be shared.
REVIEW: 117989
|
|
|
|
|
|
kconfigini.cpp:554: Class 'KConfigIniBackend' lacks Q_OBJECT macro
|
|
|
|
|
|
REVIEW:117842
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
kde5/services is kservices5
kde5/servicetypes is kservicestypes5
|
|
REVIEW: 117792
|
|
|
|
Drop KCoreAddons and KI18n dependency.
Add a bunch of QStringLiteral()
|
|
Required stopping to use some kde4support headers that were magically
injected.
|
|
It's deprecated now
|
|
|
