| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
Inside desktop files we want to reach also data, cache and config home
to create files inside these directories.
REVIEW: 127462
CHANGELOG: Add support for get QStandardPaths locations inside desktop files.
|
|
During a kconf_update run, an invalid group name may be treated as correct
even though the name failed to unescape. This leads the group name to be
a null character, which will fail.
If the unescape failed, return that failure status instead. This should have
no impact, as the previous result would have been wrong anyways. Now a
more useful diagnostic will be returned instead.
Update the unit tests to ensure this issue is tested in the future.
Found in Coverity issue 258087.
REVIEW: 126556
|
|
|
|
Due to https://codereview.qt-project.org/#/c/106473/, Qt 5.6 keeps null
characters in QByteArray -> QString conversions, which breaks this test as
one QByteArray contains nulls. Instead, convert the QByteArray to const
char * first, so QString stops at the first null.
The actual behaviour of KConfig is unchanged, as internally the conversion
always went through a const char *, which avoids creating QStrings with
null characters.
REVIEW: 126001
|
|
REVIEW: 125833
|
|
Fallback will be :/kconfig/
REVIEW: 125598
|
|
CHANGELOG: KDesktopFile can now read mime types specified in the MimeType field
REVIEW: 124746
|
|
strings-made-from-floats/doubles.
Qt 5.5 writes out "123.567001" for 123.567f. No matter, what we want is the
roundtrip float-string-float to work, and it does.
|
|
|
|
to avoid touching the user's real files
|
|
|
|
::usrWriteConfig is deprecated, use ::usrSave as recommended by the
documentation.
REVIEW: 124467
|
|
In applications translations can be looked up in the globally set
translation domain, but in libraries it is necessary to link every
i18n call to the library's own translation domain. A new code
generation option TranslationDomain= is added to enable this.
It has effect only if TranslationSystem=kde is set.
Added unit tests to check generated translation calls.
CHANGELOG: New code generation option TranslationDomain=, for use with TranslationSystem=kde; normally needed in libraries.
REVIEW: 123872
|
|
REVIEW: 124098
|
|
|
|
|
|
(CI says it happens on OSX)
Unittest it on Linux by exporting XDG_DATA_HOME with a space in it.
CCMAIL: kde-mac@kde.org
|
|
|
|
|
|
|
|
It adds a configuration setting that makes it possible to generate
Q_PROPERTY instances out of each variable exposed by the configuration
class.
Especially useful when it comes to exposing these classes to QtQuick
interfaces.
REVIEW: 123367
CHANGELOG: Generate QML-proof classes using the kconfigcompiler
|
|
ksharedconfig_in_global_object.cpp is now in kdelibs4 too
(where it works) and reproduces Albert's KgDifficulty testcase.
CHANGELOG: fix assert when using KSharedConfig in a global object destructor.
REVIEW: 122232
|
|
Add new variable to specify it in *.kcfgc : "CategoryLoggingName"
CHANGELOG: Allow to generate file with qloggingcategories support.
REVIEW: 122931
|
|
This reverts commit 9eee15917e01a89d937d1cba2eebbe9d65daeb72. As agreed
with David Faure, we are going to leave this change in place for 5.7 and
see what happens.
CCMAIL: faure@kde.org
CHANGELOG: Reverts previous commit, both can be left out of the changelog.
|
|
On further reflection, introducing a SIC to fix the bug is not ideal. I'm
working on something that will address the underlying bug, but I didn't have
it in time for 5.7.
The versioning behaviour is left, as I do want it to exist for the future.
This only reverts the mandatory versioning of files to avoid the compatibility
break.
CHANGELOG: Undo 915976c123, which never saw a release, enough to avoid the SIC.
|
|
REVIEW: 121838
Acked by Matthew Dawson
|
|
This patch is necessary because:
When we use kf5 + kde4 application, kconf_update which launchs at the start when we launch kde.
But it will migrate some config file, for example it will show that we need to migrate konversation
so it will create a konversationrc in .config/
But when we launch konversation there is a kdelibs4migrator which wants to migrate settings and config in .config
but it shows a konversationrc in .config so it will never migrate and we will lose all settings.
So we can force to remove all .upd in kf5 but it will not fix problem during migration or when we have kde4 application
install in same directory as kf5.
So now I force for each upd file to have a "Version=5" so kconf_update (kf5) will migrate just kf5 upd file and it will fix my bugs.
REVIEW: 121797
CHANGELOG: Now kconf_update doesn't process upd file from kde4. We need to add "Version=5" in top of the upd file otherwise it will be skipped.
|
|
gcc 4.5 doesn't have nullptr.
|
|
|
|
Previously the warning "Invalid escape sequence "\;"." would appear and
"\;" was replaced with just the backslash as is done for all
unrecognized escape sequences. Keep both characters so that
readXdgListEntry() works with values containing semicolons
REVIEW: 119074
|
|
|
|
This enables the mainConfig optimization in all threads,
and ensures the user warning only happens in the main thread.
The test-mode-enabled logic is only really useful in the main thread,
but it's simpler to just do it in all threads.
REVIEW: 118985
|
|
Visual C++ 2010 throws an internal compiler error trying to compile
kconfigtest, since 5f4dc2973f. I couldn't figure out a non-intrusive
code tweak that would work around the ICE, so I had to skip compiling
this particular initialization code on this particular compiler version,
and skip running the test that relies on it (testEnums).
The dummy=42 entry is so that the config group isn't empty,
which makes testGroupCopyTo and testReparent still run and pass,
so we don't need to skip them.
REVIEW:118852
|
|
- QLocale::QLocale::Austria
+ QLocale::Austria
I'm surprised this worked in gcc in the CI...
|
|
NAME_PREFIX now only changes the test name, not the target name.
|
|
This fixes a regression introduced in
988f09bb051dca0437ecec431ee44ed5b4a560d8.
The mentioned commit ensures that if the locale is e.g. "de_DE" the
entry "de" will be used. But this breaks if there is a translation
for another country. E.g. for "de_CH" it would also pick the "de"
entry.
This change now operates on both just the language code and the locale.
If an entry with the language code is present it will be picked. If
another entry with the exact locale is found it will be overwritten.
Modifiers are not supported as this is currently missing in QLocale.
REVIEW: 118692
|
|
Some tests are testing underlying components, these should be tested
before testing the components that depend on them.
REVIEW: 118680
|
|
The underlying KConfig used QLocale::name() for getting the locale
aware part. But this returns "de_DE" while the desktop files store
"de".
In addition it constructs a QLocale object instead of using the
system locale. This has the advantage that the usage of
QLocale::setDafault() gets honored by KConfig.
REVIEW: 118564
|
|
- use Q_NULLPTR instead of 0 or NULL
- simplify some foreach loops
- use QStringLiteral in a few places
- added a few consts
REVIEW: 118666
|
|
Simplify KConfigGroup::readEntry/writeEntry.
KConfigGroup::readCheck/writeCheck caused some compilers to complain
since they were private functions that were being reimplemented outside
the class definition.
Updated KCONFIGGROUP_DECLARE_ENUM_QOBJECT/
deprecated global functions created in KDE4 times.
|
|
This reverts commit 88c9a9664e99b639df4cde2be22dbe44df228879.
|
|
|
|
Open a new QFile for reading after calling close() on the temp file
|
|
|
|
We get a CMake warning for reading the LOCATION property, but I don't see
how else to do it (generator expressions don't seem to work)
|
|
The MOC files for generated output from kconfig_compiler are not automatically
generated. Re-add the code that does this, fixing the build.
I'm assuming this isn't an issue on Windows, as I don't have any machines to
test on. Please let me know if this isn't the case.
CC: arichardson.kde@gmail.com
|
|
We have to generate the files in the same directory as the test executables
otherwise QFINDTESTDATA will fail
|
|
now use QCoreApplication::applicationName() + "rc" as the config file name
instead of hardcoding the named
|
