| Age | Commit message (Collapse) | Author |
|---|
|
Previously, if a .desktop file had a TryExec and a X-KDE-AuthorizeAction
entry we would skip the KAuthorized check. This is clearly wrong.
REVIEW: 127948
|
|
The typedef is copied here to avoid including the header that contains
it. However, this confuses sip if binding definitions are generated
from the C++ headers. Simply inline the typedef instead.
|
|
|
|
Just keep the setting once and always use QString::compare instead of
using QString::operator== or QString::compare depending on the platform.
|
|
|
|
|
|
Inside desktop files we want to reach also data, cache and config home
to create files inside these directories.
REVIEW: 127462
CHANGELOG: Add support for get QStandardPaths locations inside desktop files.
|
|
Differential Revision: https://phabricator.kde.org/D990
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
This seems to be left over from KDE 3.5 times, and isn't referenced anywhere
in the code. Since its a private header, just remove.
Found by Coverity, issue 1175531.
REVIEW: 126555
|
|
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
Fallback will be :/kconfig/
REVIEW: 125598
|
|
Ran the clazy tool (http://www.kdab.com/use-static-analysis-improve-performance/)
Mostly QStringLiteral/QLatin1String additions
A few const & additions to non public methods
Compiles, test pass
REVIEW: 125106
|
|
CHANGELOG: KDesktopFile can now read mime types specified in the MimeType field
REVIEW: 124746
|
|
|
|
|
|
|
|
It's called a lot at startup as shown by profiling.
heaptrack also complains it does many heap allocations, so cache it.
REVIEW: 124199
|
|
|
|
REVIEW: 124467
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
ksharedconfig_in_global_object.cpp is now in kdelibs4 too
(where it works) and reproduces Albert's KgDifficulty testcase.
CHANGELOG: fix assert when using KSharedConfig in a global object destructor.
REVIEW: 122232
|
|
QByteArrayLiteral
|
|
|
|
The local config file gets locked on line 415, if we return early we
need to unlock it.
REVIEW: 122549
BUG: 344032
|
|
which was always TRUE
REVIEW: 122445
|
|
With -Winconsistent-missing-override (Clang), headers from KConfig are
throwing a lot of warnings.
REVIEW: 122539
|
|
|
|
REVIEW: 121838
Acked by Matthew Dawson
|
|
|
|
|
|
KSharedConfig has been ported to QStandardPaths in KF5.
REVIEW: 121272
|
|
|
|
|
|
gcc 4.5 doesn't support "#pragma GCC diagnostic" inside functions.
Apparently it also doesn't support "#pragma GCC diagnostic push/pop",
but it doesn't fail for that, so meh.
|
|
Add a class description to KConfigBase so that KConfig::sync can link to
KConfigBase::sync. Also makes KConfigBase easier to find and understand.
|
|
KConfig fails building because QBasicAtomicInt is being treated as an int.
REVIEW: 119417
|
|
|
|
Previously the warning "Invalid escape sequence "\;"." would appear and
"\;" was replaced with just the backslash as is done for all
unrecognized escape sequences. Keep both characters so that
readXdgListEntry() works with values containing semicolons
REVIEW: 119074
|
|
|
|
This enables the mainConfig optimization in all threads,
and ensures the user warning only happens in the main thread.
The test-mode-enabled logic is only really useful in the main thread,
but it's simpler to just do it in all threads.
REVIEW: 118985
|
|
|
|
|
|
... by having a different list of shareable objects per thread.
REVIEW: 118739
|
|
This fixes a regression introduced in
988f09bb051dca0437ecec431ee44ed5b4a560d8.
The mentioned commit ensures that if the locale is e.g. "de_DE" the
entry "de" will be used. But this breaks if there is a translation
for another country. E.g. for "de_CH" it would also pick the "de"
entry.
This change now operates on both just the language code and the locale.
If an entry with the language code is present it will be picked. If
another entry with the exact locale is found it will be overwritten.
Modifiers are not supported as this is currently missing in QLocale.
REVIEW: 118692
|
|
Yet another awesome application of the Qt implicit sharing trick.
Since config files often contain only few different keys and even
value strings, we can share them. This reduces memory consumption
and also speeds up parsing, as we do not have to allocate the
duplicated strings, but can simply reuse the previous values.
The most extreme case for this of my knowledge, is KatePart:
katesyntaxhighlightingrc has more than 20k lines which triggered
nearly 30k allocations on startup. With this patch applied, this
value goes down dramatically. I added a simple static counter for
the cache hit/miss ratio, which resulted in 5442 cache misses compared
to 43624 cache hits across all KConfig files parsed by kwrite.
REVIEW: 118587
This is a forward-port of b8aaeff128233cfaecf67899168887572589dde8.
|
