Age | Commit message (Collapse) | Author |
|
|
|
The "dir" and "path" variables were obviously swapped here by mistake.
This resulted in the relativePath always being empty, and made the
function return "~/.local/share/" (or "~/.config/") instead of the
correct path.
BUG: 345100
FIXED-IN: 5.34.0
Differential Revision: https://phabricator.kde.org/D5502
|
|
Spotted because it leads to race conditions due to tzset
(surely a Qt bug, but anyway no point in finding out lastModified
for nothing).
While at it, remove the unused size field as well.
|
|
clarity.
|
|
Differential Revision: https://phabricator.kde.org/D4941
|
|
Summary:
It can't possibly have been used anywhere, because it's not in the KConfig
API anywhere. The intended way to use this API was by providing a plugin
that would derive from KConfigBackend but the plugin loading code
in KConfigBackend::create has been disabled since before KF 5.0.
The reason I want to stop exporting this class is to be able to
optimize it (e.g. the QDateTime in it is completely unused but leads
to data races due to tzset)
Test Plan: Note, I'll rename it to _p.h if we agree, it would just have made this diff too big.
Reviewers: mdawson
Reviewed By: mdawson
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D4604
|
|
Even with 5.8 we need it, not due to QLockFile, but just due to mainConfigName(),
see unittest ksharedconfig_in_global_object
|
|
It's not needed, this is purely a test for the standalone KEntryMap class.
|
|
It is internal.
|
|
|
|
Differential Revision: https://phabricator.kde.org/D3987
|
|
|
|
|
|
|
|
|
|
REVIEW: 129745
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
Summary: use qEnvironmentVariableIsSet instead of qgetenv().isEmpty()
Reviewers: #frameworks, sebas, sitter
Reviewed By: sebas, sitter
Differential Revision: https://phabricator.kde.org/D3314
|
|
|
|
|
|
Don't drop the file: prefix twice in every run.
Use appropriate API on paths rather than string handling, when possible.
REVIEW: 127813
|
|
CCMAIL: elvis.angelaccio@kdemail.net
|
|
REVIEW: 128023
|
|
Previously, if a .desktop file had a TryExec and a X-KDE-AuthorizeAction
entry we would skip the KAuthorized check. This is clearly wrong.
REVIEW: 127948
|
|
The typedef is copied here to avoid including the header that contains
it. However, this confuses sip if binding definitions are generated
from the C++ headers. Simply inline the typedef instead.
|
|
|
|
Just keep the setting once and always use QString::compare instead of
using QString::operator== or QString::compare depending on the platform.
|
|
|
|
|
|
Inside desktop files we want to reach also data, cache and config home
to create files inside these directories.
REVIEW: 127462
CHANGELOG: Add support for get QStandardPaths locations inside desktop files.
|
|
Differential Revision: https://phabricator.kde.org/D990
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
This seems to be left over from KDE 3.5 times, and isn't referenced anywhere
in the code. Since its a private header, just remove.
Found by Coverity, issue 1175531.
REVIEW: 126555
|
|
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
|
|
Fallback will be :/kconfig/
REVIEW: 125598
|
|
Ran the clazy tool (http://www.kdab.com/use-static-analysis-improve-performance/)
Mostly QStringLiteral/QLatin1String additions
A few const & additions to non public methods
Compiles, test pass
REVIEW: 125106
|
|
CHANGELOG: KDesktopFile can now read mime types specified in the MimeType field
REVIEW: 124746
|
|
|
|
|
|
|
|
It's called a lot at startup as shown by profiling.
heaptrack also complains it does many heap allocations, so cache it.
REVIEW: 124199
|
|
|
|
REVIEW: 124467
|
|
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
|
|
ksharedconfig_in_global_object.cpp is now in kdelibs4 too
(where it works) and reproduces Albert's KgDifficulty testcase.
CHANGELOG: fix assert when using KSharedConfig in a global object destructor.
REVIEW: 122232
|