| Age | Commit message (Collapse) | Author |
|---|
|
A window that is maximized does not really have a position on screen
other then the fact that it's maximized, and writing out position data
in this case anyway will only serve to mis-position the window once
da-maximized, should KWin ever stop remembering de-maximized window
positions internally.
CCBUG: 434116
|
|
- Use QString::arg(Args...) instead of .arg().arg()
- Use QLatin1String for string comparisons, should be faster
- Use QLatin1String::arg() for better readability
- Add the comment dfaure suggested in the MR, to explain why it's '2%'
then '%1' in a QString().arg().arg()
NO_CHANGELOG
|
|
NO_CHANGELOG
|
|
We have a fallback string that gets searched for in the KCM, but that
fallback itself should not have a fallback, or else we always use that
second fallback and the window gets positioned incorrectly the first
time it's opened. So let's replace the second fallback with -1.
BUG: 432661
FIXED-IN: 5.79
|
|
This commit refactors the code a bit to define the window geometry
strings in one place and uses a common method to read and write them.
This makes future changes much less fragile and fixes a pre-existing bug
that had gone un-noticed which caused window positions to not be saved
on a per-resolution basis in addition to a per-display-arrangement
basis. Old strings are used if available to that people don't lose their
saved position data the first time they upgrade to KF 5.79.
|
|
The maximization string was being saved to the config file including
the connected screens, but the code to read it was not, and was also
looking for the old incorrect format. This could have resulted in old
config values being used forever, and the window always being opened
in a maximized state.
BUG: 430521
FIXED-IN: 5.79
|
|
When a window is closed while maximized, we write a special string to
the config file so that it gets restored in its maximized state. But we
don't ever delete that thing when the window is un-maximized and closed
again, causing the window to always be maximized when launched.
BUG: 426813
FIXED-IN: 5.78
|
|
All other resolutions are stored in the form of width x height, but a
silly transposition error had the maximized strong being height x width.
That's fixed now.
|
|
The feature to make windows remember their sizes and positions across
screen layouts relied on calling QScreen::name() to identify screens.
Unfortunately this function returns garbage on Windows; see
https://bugreports.qt.io/browse/QTBUG-74317
So on Windows, let's identify displays by serial number as a workaround.
BUG: 429943
FIXED-IN: 5.78
|
|
It doesn't need to be public since it's just an internal convenience
function. So let's make it static.
BUG: 425953
|
|
This is done for window positions, so it should also be done for
window sizes. The combination of both should substantially improve the
use case of maintaining a consistent window arrangement for multiple
display setups (e.g. laptop and laptop + external screen).
|
|
Right now it's duplicated twice, and once we add per-screen-arrangement
memory for window sizes as well, it will be duplicated four times unless
we put it into a function.
|
|
These functions allow an application to save and restore the positions
of its windows. Positions are stored on a per-screen-arrangement basis.
For example with a single screen connected, the config file would have
entries like this in it:
eDP-1 XPosition=140
eDP-1 YPosition=340
When a second screen is connected, the following gets saved:
eDP-1 HDMI-1 XPosition=3878
eDP-1 HDMI-1 YPosition=29
This ensures that each separate screen arrangement can have its own
saved window position, which is handy for the use case where you have a
laptop that you plug into an external screen some of the time. It also
allows the position to get restored to the correct screen when there are
multiple screens.
This is a necessary first step to getting KDE apps to save their window
positions on X11 The next step would be calling the new functions from
KXMLGui and Kirigami apps, and then porting all apps that manually invoke
KWindowConfig::saveWindowSize() and KWindowConfig::restoreWindowSize()
to also invoke KWindowConfig::saveWindowPosition() and
KWindowConfig::restoreWindowPosition() in the same places.
The functions only work on X11 or other non-Wayland platforms. On
Wayland, the compositor has sole dominion over window positioning so a
compositor-specific solution much be adopted instead, such as
https://bugs.kde.org/show_bug.cgi?id=15329.
CCBUG: 415150
|
|
Summary:
Convert license headers to SPDX statements and add
license files as required by REUSE specification.
Reviewers: cgiboudeaux
Reviewed By: cgiboudeaux
Subscribers: ognarb, cgiboudeaux, kde-frameworks-devel
Tags: #frameworks
Maniphest Tasks: T11550
Differential Revision: https://phabricator.kde.org/D27601
|
|
Ran the clazy tool (http://www.kdab.com/use-static-analysis-improve-performance/)
Mostly QStringLiteral/QLatin1String additions
A few const & additions to non public methods
Compiles, test pass
REVIEW: 125106
|
|
Reviewed by Handa
|
|
|
|
Use git blame -w 867e7a5 to show authorship as it was before this commit.
|
|
|
