Age | Commit message (Collapse) | Author |
|
Summary: FEATURE: Use Ctrl+Shift+, as the standard keyboard shortcut to invoke KDE programs' "Configure <Program>" menu items.
Test Plan:
This shortcut is not used by anything else. Searched on lxr, found one conflict in DigiKam, and the developers agreed to change it: https://bugs.kde.org/show_bug.cgi?id=386335
Will wait to land this until Digikam 5.8.0 is released to prevent any shortcut conflicts.
Tested in KDE Neon. Tried out Plasma, KWin, Dolphin, Kate, Konsole, Gwenview, Okular, Konversation, KTorrent, and Skanlite; all now have a consistent keyboard shortcut for their "Configure <Program>" menu items.
Reviewers: #frameworks, #vdg, broulik, rkflx
Reviewed By: rkflx
Subscribers: ilic, abetts, elvisangelaccio, aacid, argonel, marten, graesslin, broulik, #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D8296
|
|
|
|
|
|
Qt doesn't make it easy for us to just use QWindow...
|
|
For consistency with D7293.
Differential Revision: https://phabricator.kde.org/D7758
|
|
Differential Revision: https://phabricator.kde.org/D7605
|
|
For consistency with D6774.
CCBUG: 382450
Differential Revision: https://phabricator.kde.org/D6775
|
|
Summary:
This is particularly useful for cross-compilation, where we only need the
kconfig_compiler on the host system.
Reviewers: #frameworks, apol, aacid
Reviewed By: aacid
Subscribers: aacid
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D6994
|
|
Summary:
This is what other webbrowsers like Firefox and Chrome do,
and is certainly much more international than Ctrl+Comma/Ctrl+Dot which
is very qwerty centric.
Test Plan: Switching tabs in Konqueror
Reviewers: mdawson
Subscribers: #frameworks
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D6553
|
|
Using the new extra-cmake-modules module ECMAddQch (since 5.36.0)
this adds the option to automatically build and install a file
in QCH format with the docs about the public API, which then can be
used e.g. in Qt Assistant, Qt Creator or KDevelop.
Additionally the installed cmake config files will be extended
with a target KF5Config_QCH containing information about how to "link"
into the generated QCH file, which then can be used in the cmake build
system of other libraries building on this library, by
simply listing this target in "LINK_QCHS" of their ecm_add_qch() usage.
And a respective doxygen tag file with all the metadata about the
generated QCH file and used for the "linking" will be created and
installed.
Pass -DBUILD_QCH=ON to cmake to enable this.
|
|
|
|
For some reason some people have kdeglobals entries like
Close=Ctrl+W; Ctrl+Esc; Ctrl+W; Ctrl+Esc;
having the same shortcut more than once in the shortcut declaration is clearly bogus so fix it
BUGS: 375555
REVIEW: 129987
|
|
|
|
Differential Revision: https://phabricator.kde.org/D3987
|
|
|
|
|
|
REVIEW: 128608
CHANGELOG: Add Donate entry to KStandardShortcut
|
|
REVIEW: 128517
|
|
No one could be using this because they would not be able to link,
|
|
This way it can be shown in the apidox.
|
|
|
|
Generate-source-file macros should be used from the same CMakeLists.txt
file as the targets they generate files for.
|
|
Ran the clazy tool (http://www.kdab.com/use-static-analysis-improve-performance/)
Mostly QStringLiteral/QLatin1String additions
A few const & additions to non public methods
Compiles, test pass
REVIEW: 125106
|
|
Don't build error string every time
REVIEW: 124879
|
|
|
|
Reviewed by Handa
|
|
|
|
When the application receives a saveState signal it needs to replace the
current KConfig object with a new one based on the QSessionManager
information. Add a new interface that accepts the new session id and key.
BUG: 346768
REVIEW: 123705
|
|
With -Winconsistent-missing-override (Clang), headers from KConfig are
throwing a lot of warnings.
REVIEW: 122539
|
|
when parsing the default value for string lists, skip empty parts
also, an empty string means an empty list (not a list containing
an empty string)
|
|
Fixes build with Qt 5.5
|
|
|
|
REVIEW:120947
|
|
this way we actually get the same shared pointer and thus does not
require a sync() call on the config object to get the right values
REVIEW:120283
|
|
|
|
This is needed so doxygen includes the far more useful documentation on
the contained methods.
|
|
Switch to using QT_TRANSLATE_NOOP3 so that context information can be
given for actions, allowing the translators to do better translations.
BUG: 337979
FIXED-IN: 5.2.0
REVIEW: 119577
|
|
using Qt-standard QT_TRANSLATE_NOOP instead of a fake I18N_NOOP2
|
|
- use Q_NULLPTR instead of 0 or NULL
- simplify some foreach loops
- use QStringLiteral in a few places
- added a few consts
REVIEW: 118666
|
|
This should have been part of 8b88eaee.
REVIEW: 118339
|
|
|
|
|
|
This is instead of INCLUDE_INSTALL_DIR and INSTALL_TARGETS_DEFAULT_ARGS,
which will lose the "KF5" suffix from the include path.
|
|
The extra load of values in KCoreConfigSkeleton is not documented anywhere
that it happens, and in normal circumstances re-loading new values isn't
expecterd during a save operation.
Update various mentions of readConfig/writeConfig to read/save.
Update documentation to match the new names of functions.
Rename writeConfig() to save() and usrWriteConfig() to usrSave()
Rename functions to match the new naming conventions. Also create old deprecated
instances of both functions to ensure that old code continues to operate
correctly. Also make save() non-virtual, for the same reasons read() is
now non-virtual.
Rename usrReadConfig to usrRead, to be consistent with the new name for readConfig.
Rename usrReadConfig to usrRead, and mark the former as deprecated. To maintain
compatibility, usrRead still calls usrReadConfig in its default implementation.
usrReadConfig remains empty.
REVIEW: 117010
|
|
|
|
|
|
|
|
QtTest and QtConcurrent are only required for autotests, so no need
to find them unconditionally.
QtWidgets is not actually used - QtGui is instead.
REVIEW: 114962
|
|
|
|
Install them in the proper directory.
Let cmake find them.
Had to rename conversion_check.h to conversioncheck.h
Had to improve the scripts to support multiple libs in one framework :)
|