aboutsummaryrefslogtreecommitdiff
path: root/src/kconf_update
AgeCommit message (Collapse)Author
2020-03-22KConfig: Convert to SPDX license statementsAndreas Cord-Landwehr
Summary: Convert license headers to SPDX statements and add license files as required by REUSE specification. Reviewers: cgiboudeaux Reviewed By: cgiboudeaux Subscribers: ognarb, cgiboudeaux, kde-frameworks-devel Tags: #frameworks Maniphest Tasks: T11550 Differential Revision: https://phabricator.kde.org/D27601
2020-02-12Use ecm_qt_install_logging_categories over manual categories fileFriedrich W. H. Kossebau
2020-01-03Remove endl at the end of qdebugLaurent Montel
2019-09-17[KConfig] port away from deprecated methods in Qt 5.14David Faure
Summary: In kconf_update, the ctime usage used to be about metadata change time (buff.st_ctime, before it got ported to the misnamed created()). I ported it to birthTime, because I think date of birth is a more useful way to identify a file than date of permission change which doesn't really matter to us. But in practice, I can't help but wonder if mtime alone wouldn't be enough. For the QStringLiteral("%%1").arg(i) bit, I tested it in tst_qstring, the first % is left untouched. Test Plan: make && ctest Reviewers: mdawson, arichardson, vkrause Reviewed By: vkrause Subscribers: pino, arojas, mlaurent, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D23815
2019-08-24String code optimization: use QLatin1String/QChar overload for string concatFriedrich W. H. Kossebau
GIT_SILENT
2019-03-26point readme to the wiki pageHarald Sitter
Summary: the wiki page says the readme is duplicated into the wiki. so, what we end up with is either - they end up out of sync - someone gets real angry because the wiki needs format markup while the readme must not have markup - someone doesn't get angry and simply copies either markup or nomarkup to the respectively unsuitable target it's an unsustainable situation... so instead let's point the readme to the wiki and consider that the place where the documentation is maintained Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D19779
2019-03-12[kconf_update] move from custom logging tech to qCDebugHarald Sitter
Summary: the previous logging tech got kind of defunct in 2014 (to the point where it was basically qCDebug). seeing as no one really complained it seems reasonable to just move to qCDebug instead and make use of category filters and other qdebug goodness (such as system logging facilities for the various platforms) - new logging category kf5.kconfig.update; at info level by default (i.e. unless otherwise configured kconf_update is now silent) - --debug cmdline option now also attempts to force-enable the debug mode on that category (and debugs that attempt in of itself, so we don't get confused by categories magically getting enabled). - all log() calls are now qCDebug calls - all logFileErorr() calls (which was context-sensitive to the .upd file parsing) have been changed to qCDebugFile - qCDebugFile is a new *macro* wrapping around qCDebug to give it file context - everything is now qCDebug instead of qDebug - arguments updated to drop excess quoting and spaces to reduce "noise" https://markmail.org/thread/ofaeqcabguxyohyb Test Plan: updater still works and debugs when debug is enabled Reviewers: apol, aacid, #frameworks Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D19508
2019-03-03[Kconfig] Compile without foreachLaurent Montel
Summary: compile without foreach Test Plan: Unittest Ok as previously Reviewers: dfaure Reviewed By: dfaure Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D19326
2019-01-09KonfUpdate: delete copy constructor and assignment operatorAlbert Astals Cid
they are unused, but if anyone would use them things would go wrong, so protect us from it
2018-03-11Remove not necessary QtCore and coLaurent Montel
2018-02-05Export kconf_update with toolingAleix Pol
Summary: This way if another cmake project imports it when cross-compiling, it can be executed. Reviewers: #frameworks Tags: #frameworks Differential Revision: https://phabricator.kde.org/D9652
2017-08-04Allow to build KConfig without Qt5GuiVolker Krause
Summary: This is particularly useful for cross-compilation, where we only need the kconfig_compiler on the host system. Reviewers: #frameworks, apol, aacid Reviewed By: aacid Subscribers: aacid Tags: #frameworks Differential Revision: https://phabricator.kde.org/D6994
2017-07-03API dox: update url from kdelibs to kconfigFriedrich W. H. Kossebau
2017-01-16Prefer nullptr over Q_NULLPTRKevin Funk
2017-01-03Fix build with CMP 0026 set to NEWSven Brauch
2015-12-29Ensure KonfUpdate's fields are all initialized.Matthew Dawson
These fields should all be written to before they are read during normal operation, but this ensures they have a sensible default in case they are not. Coverity issue 1291513.
2015-12-29Ensure group is unescaped properly in kconf_update.Matthew Dawson
During a kconf_update run, an invalid group name may be treated as correct even though the name failed to unescape. This leads the group name to be a null character, which will fail. If the unescape failed, return that failure status instead. This should have no impact, as the previous result would have been wrong anyways. Now a more useful diagnostic will be returned instead. Update the unit tests to ensure this issue is tested in the future. Found in Coverity issue 258087. REVIEW: 126556
2015-12-23Fix some Clazy warningsImran Tatriev
2015-10-05Minor optimizationsAlbert Astals Cid
Ran the clazy tool (http://www.kdab.com/use-static-analysis-improve-performance/) Mostly QStringLiteral/QLatin1String additions A few const & additions to non public methods Compiles, test pass REVIEW: 125106
2015-08-05finish the port to QCommandLineParser (it has addPositionalArgument now)David Faure
2015-08-05test_kconf_update: use QStandardPaths test modeDavid Faure
to avoid touching the user's real files
2015-08-01Upgrade Qt version requirement to 5.3David Faure
2015-05-02Fix kconf_update for spaces in pathsDavid Faure
(CI says it happens on OSX) Unittest it on Linux by exporting XDG_DATA_HOME with a space in it. CCMAIL: kde-mac@kde.org
2015-02-14Revert "Revert the SIC in commit 915976c1238be811f169eab1b02f7e8dad6410e0."Matthew Dawson
This reverts commit 9eee15917e01a89d937d1cba2eebbe9d65daeb72. As agreed with David Faure, we are going to leave this change in place for 5.7 and see what happens. CCMAIL: faure@kde.org CHANGELOG: Reverts previous commit, both can be left out of the changelog.
2015-02-14Revert the SIC in commit 915976c1238be811f169eab1b02f7e8dad6410e0.Matthew Dawson
On further reflection, introducing a SIC to fix the bug is not ideal. I'm working on something that will address the underlying bug, but I didn't have it in time for 5.7. The versioning behaviour is left, as I do want it to exist for the future. This only reverts the mandatory versioning of files to avoid the compatibility break. CHANGELOG: Undo 915976c123, which never saw a release, enough to avoid the SIC.
2015-01-10Update installation variables.Alex Merry
2015-01-06Don't upgrate config file with upd file from kde4.Montel Laurent
This patch is necessary because: When we use kf5 + kde4 application, kconf_update which launchs at the start when we launch kde. But it will migrate some config file, for example it will show that we need to migrate konversation so it will create a konversationrc in .config/ But when we launch konversation there is a kdelibs4migrator which wants to migrate settings and config in .config but it shows a konversationrc in .config so it will never migrate and we will lose all settings. So we can force to remove all .upd in kf5 but it will not fix problem during migration or when we have kde4 application install in same directory as kf5. So now I force for each upd file to have a "Version=5" so kconf_update (kf5) will migrate just kf5 upd file and it will fix my bugs. REVIEW: 121797 CHANGELOG: Now kconf_update doesn't process upd file from kde4. We need to add "Version=5" in top of the upd file otherwise it will be skipped.
2014-06-12Simple CleanupsThomas Braxton
- use Q_NULLPTR instead of 0 or NULL - simplify some foreach loops - use QStringLiteral in a few places - added a few consts REVIEW: 118666
2014-05-23Fix searching of paths in kconf_updateDavid Edmundson
Previous code said if we found an executable in kconf_update_bin try to find a different executable in the normal path Reviewed-by: Rohan Garg
2014-05-07Fix kconf_update test on WindowsAlex Richardson
We get a CMake warning for reading the LOCATION property, but I don't see how else to do it (generator expressions don't seem to work)
2014-05-07Use QProcess in kconf_updateAlex Richardson
This allows removing some custom WIN32 API code and is also nicer than directly calling system()
2014-04-27install libexec executables in the kf5 libexec directoryAleix Pol
2014-03-25Export the location of kconf_update in CMakeAlex Merry
This is for the benefit of kded, which needs to run this binary. REVIEW: 117023
2014-03-24Remove unhelpful commentsAlex Merry
These lines of code do not really require any justification. REVIEW: 116962
2013-12-18Code reformatted using kde-dev-scripts/astyle-kdelibs.David Faure
Use git blame -w 867e7a5 to show authorship as it was before this commit.
2013-12-18Move kconfig code to the root directory.Jenkins CI