| Age | Commit message (Collapse) | Author | 
 | 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 | 
 | 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 | 
 | 
Summary:
Better specify the requirements the parent class needs to have.
KConfigCompiler generates different variants of ctors taking either:
 * a QStringLiteral argument (name set in <kcfgfile>
 * a KSharedConfig::Ptr argument (arg="true" in <kcfgfile>)
 * no argument (Inherits=true in kcfgc and no <kcfgfile>)
In order to have Inherits generate compiling code in all cases the
parent class needs to provide accessible ctors.
This change updates the docuementation to reflect this.
Reviewers: #frameworks, dfaure
Differential Revision: https://phabricator.kde.org/D3636
 | 
 | 
Reviewers: #frameworks, davidedmundson
Reviewed By: davidedmundson
Differential Revision: https://phabricator.kde.org/D3702
 | 
 | 
This reverts commit cd4e6504dfbdface00037625f0cedda511e6d839.
As suggested by Martin on release-team@kde.org, given that it breaks SC.
 | 
 | 
Summary:
In case a kcfg with arg="true" was used and singleton the static
instance method only accepted a QString config name. This made it
impossible to combine a singleton config with an already existing and
open KSharedConfig::Ptr.
With this change an overloaded instance method is added which takes a
KSharedConfig::Ptr as argument. The private ctor, though, only takes a
KSharedConfig::Ptr and the instance method taking a QString argument
uses KSharedConfig::openConfig on the config file name.
This provides full API compatibility and at the same time allows to use
KSharedConfig in addition to the arg name based variant.
Test Plan:
kconfigcompiler tests still pass and a config with singleton
and arg="true" generates the code as I need it
Reviewers: #frameworks
Differential Revision: https://phabricator.kde.org/D3386
 | 
 | 
Summary: use qEnvironmentVariableIsSet instead of qgetenv().isEmpty()
Reviewers: #frameworks, sebas, sitter
Reviewed By: sebas, sitter
Differential Revision: https://phabricator.kde.org/D3314
 | 
 | 
REVIEW: 129382
 | 
 | 
 | 
 | 
REVIEW: 129188
 | 
 | 
 | 
 | 
REVIEW: 128608
CHANGELOG: Add Donate entry to KStandardShortcut
 | 
 | 
 | 
 | 
REVIEW: 128517
 | 
 | 
Don't drop the file: prefix twice in every run.
Use appropriate API on paths rather than string handling, when possible.
REVIEW: 127813
 | 
 | 
CCMAIL: elvis.angelaccio@kdemail.net
 | 
 | 
REVIEW: 128023
 | 
 | 
REVIEW:128102
Set encoding on kconfig_compiler generated cpp and headers
to utf-8 ( reproducible builds ) Under certain locals non
standard characters will get dropped making builds un reproducible.
Setting the encoding to utf-8 on the files makes all builds reproducible
no matter what ( or none ) locale is in use. Thereby making the build reproducible.
 | 
 | 
Previously, if a .desktop file had a TryExec and a X-KDE-AuthorizeAction
entry we would skip the KAuthorized check. This is clearly wrong.
REVIEW: 127948
 | 
 | 
No one could be using this because they would not be able to link,
 | 
 | 
The typedef is copied here to avoid including the header that contains
it.  However, this confuses sip if binding definitions are generated
from the C++ headers.  Simply inline the typedef instead.
 | 
 | 
 | 
 | 
Just keep the setting once and always use QString::compare instead of
using QString::operator== or QString::compare depending on the platform.
 | 
 | 
 | 
 | 
 | 
 | 
Inside desktop files we want to reach also data, cache and config home
to create files inside these directories.
REVIEW: 127462
CHANGELOG: Add support for get QStandardPaths locations inside desktop files.
 | 
 | 
Differential Revision: https://phabricator.kde.org/D990
 | 
 | 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 | 
 | 
 | 
 | 
These fields should all be written to before they are read during normal
operation, but this ensures they have a sensible default in case they are not.
Coverity issue 1291513.
 | 
 | 
This seems to be left over from KDE 3.5 times, and isn't referenced anywhere
in the code.  Since its a private header, just remove.
Found by Coverity, issue 1175531.
REVIEW: 126555
 | 
 | 
During a kconf_update run, an invalid group name may be treated as correct
even though the name failed to unescape.  This leads the group name to be
a null character, which will fail.
If the unescape failed, return that failure status instead.  This should have
no impact, as the previous result would have been wrong anyways.  Now a
more useful diagnostic will be returned instead.
Update the unit tests to ensure this issue is tested in the future.
Found in Coverity issue 258087.
REVIEW: 126556
 | 
 | 
This has been around for a long time, no need to dupilcate.
Coverity issue 1289077.
 | 
 | 
This way it can be shown in the apidox.
 | 
 | 
 | 
 | 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 | 
 | 
In case of conflict in i18n, keep the version of the branch "ours"
To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
 | 
 | 
Generate-source-file macros should be used from the same CMakeLists.txt
file as the targets they generate files for.
 | 
 | 
REVIEW: 125833
 | 
 | 
 | 
 | 
Fallback will be :/kconfig/
REVIEW: 125598
 | 
 | 
Ran the clazy tool (http://www.kdab.com/use-static-analysis-improve-performance/)
Mostly QStringLiteral/QLatin1String additions
A few const & additions to non public methods
Compiles, test pass
REVIEW: 125106
 | 
 | 
Makes sure that it doens't create an app bundle on Mac OS X
REVIEW: 125337
 | 
 | 
CHANGELOG: KDesktopFile can now read mime types specified in the MimeType field
REVIEW: 124746
 | 
 | 
Don't build error string every time
REVIEW: 124879
 | 
 | 
 | 
 | 
 | 
 | 
Because it allocates memory.
REVIEW: 124717
 | 
 | 
 | 
 | 
It's called a lot at startup as shown by profiling.
heaptrack also complains it does many heap allocations, so cache it.
REVIEW: 124199
 |