From dc878289c01011c59615746655b4e78d4bc90b91 Mon Sep 17 00:00:00 2001 From: Ahmad Samir Date: Wed, 3 Feb 2021 15:28:38 +0200 Subject: Minor code optimisations - Use a global var for a QString that's used many times - Break up long-all-cap variable names, it makes it harder to read (and I've fixed one typo in one of those ALLCAPS) - Fix some clazy warnings, make global QString objects in unit tests static (so that the compiler doesn't create symbols for them, it doesn't matter in a unit test but KF code acts as a reference sometimes that others copy from, tip from dfaure) - Add TODO note about changing kconfig_compiler to generate C++ code that uses multi-arg QString::arg(QString, QString, QString) instead of QString::arg().arg() - More const; more QString::at() instead of operator[] where appropriate - Use a ternary where it makes the code more readable (and uses less lines :)) NO_CHANGELOG --- autotests/kentrymaptest.cpp | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'autotests/kentrymaptest.cpp') diff --git a/autotests/kentrymaptest.cpp b/autotests/kentrymaptest.cpp index 406e4e99..d571f761 100644 --- a/autotests/kentrymaptest.cpp +++ b/autotests/kentrymaptest.cpp @@ -8,11 +8,13 @@ #include -const QByteArray group1("A Group"); -const QByteArray key1("A Key"); -const QByteArray key2("Another Key"); -const QByteArray value1("A value"); -const QByteArray value2("A different value"); +// clazy:excludeall=non-pod-global-static + +static const QByteArray group1{"A Group"}; +static const QByteArray key1{"A Key"}; +static const QByteArray key2{"Another Key"}; +static const QByteArray value1{"A value"}; +static const QByteArray value2{"A different value"}; QTEST_MAIN(KEntryMapTest) -- cgit v1.2.1