From 38b51667b5ba74fc5a28172e251c9ba4c0398e32 Mon Sep 17 00:00:00 2001 From: Laurent Montel Date: Tue, 26 Feb 2019 07:04:22 +0100 Subject: [Kconfig] Compile without foreach Summary: compile without foreach Test Plan: Unittest Ok as previously Reviewers: dfaure Reviewed By: dfaure Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D19326 --- src/core/kconfiggroup.h | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'src/core/kconfiggroup.h') diff --git a/src/core/kconfiggroup.h b/src/core/kconfiggroup.h index f5e16fdb..0cedeaa7 100644 --- a/src/core/kconfiggroup.h +++ b/src/core/kconfiggroup.h @@ -731,12 +731,13 @@ QList KConfigGroup::readEntry(const char *key, const QList &defaultValue) QVariantList data; - Q_FOREACH (const T &value, defaultValue) { + for (const T &value : defaultValue) { data.append(qVariantFromValue(value)); } QList list; - Q_FOREACH (const QVariant &value, readEntry(key, data)) { + const auto variantList = readEntry(key, data); + for (const QVariant &value : variantList) { Q_ASSERT(value.canConvert()); list.append(qvariant_cast(value)); } @@ -757,7 +758,7 @@ void KConfigGroup::writeEntry(const char *key, const QList &list, WriteConfig ConversionCheck::to_QVariant(); ConversionCheck::to_QString(); QVariantList data; - Q_FOREACH (const T &value, list) { + for (const T &value : list) { data.append(qVariantFromValue(value)); } -- cgit v1.2.1