From 49203c61c7b6fc9629e85b118bdfcd1c468287ca Mon Sep 17 00:00:00 2001 From: Aleix Pol Date: Wed, 9 Nov 2016 00:54:56 +0100 Subject: Properly test environment variable Summary: use qEnvironmentVariableIsSet instead of qgetenv().isEmpty() Reviewers: #frameworks, sebas, sitter Reviewed By: sebas, sitter Differential Revision: https://phabricator.kde.org/D3314 --- src/core/ksharedconfig.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/core/ksharedconfig.cpp') diff --git a/src/core/ksharedconfig.cpp b/src/core/ksharedconfig.cpp index f2de85be..c2997e9d 100644 --- a/src/core/ksharedconfig.cpp +++ b/src/core/ksharedconfig.cpp @@ -109,8 +109,8 @@ KSharedConfigPtr KSharedConfig::openConfig(const QString &_fileName, static bool userWarned = false; if (isMainThread && !userWarned) { userWarned = true; - QByteArray readOnly = qgetenv("KDE_HOME_READONLY"); - if (readOnly.isEmpty() && QCoreApplication::applicationName() != QLatin1String("kdialog")) { + const bool isReadOnly = qEnvironmentVariableIsEmpty("KDE_HOME_READONLY"); + if (isReadOnly && QCoreApplication::applicationName() != QLatin1String("kdialog")) { if (ptr->group("General").readEntry(QStringLiteral("warn_unwritable_config"), true)) { ptr->isConfigWritable(true); } -- cgit v1.2.1