From 33bcefa50dcf925f2e960957ab8e3edfd9c67338 Mon Sep 17 00:00:00 2001 From: Albert Astals Cid Date: Mon, 30 Sep 2019 21:31:24 +0200 Subject: Small performance enhacements Summary: suggested by clang-tidy Reviewers: davidedmundson Reviewed By: davidedmundson Subscribers: kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D24312 --- src/core/kconfigwatcher.cpp | 2 +- src/core/kcoreconfigskeleton.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/core') diff --git a/src/core/kconfigwatcher.cpp b/src/core/kconfigwatcher.cpp index 1aec1211..4d4d1355 100644 --- a/src/core/kconfigwatcher.cpp +++ b/src/core/kconfigwatcher.cpp @@ -70,7 +70,7 @@ KConfigWatcher::KConfigWatcher(const KSharedConfig::Ptr &config): QStringList watchedPaths; watchedPaths << QLatin1Char('/') + d->m_config->name(); - for (const QString file: d->m_config->additionalConfigSources()) { + for (const QString &file: d->m_config->additionalConfigSources()) { watchedPaths << QLatin1Char('/') + file; } if (d->m_config->openFlags() & KConfig::IncludeGlobals) { diff --git a/src/core/kcoreconfigskeleton.cpp b/src/core/kcoreconfigskeleton.cpp index 2d8048a2..b3eb0019 100644 --- a/src/core/kcoreconfigskeleton.cpp +++ b/src/core/kcoreconfigskeleton.cpp @@ -1009,7 +1009,7 @@ KCoreConfigSkeleton::KCoreConfigSkeleton(KSharedConfig::Ptr pConfig, QObject *pa d(new KCoreConfigSkeletonPrivate) { //qDebug() << "Creating KCoreConfigSkeleton (" << (void *)this << ")"; - d->mConfig = pConfig; + d->mConfig = std::move(pConfig); } KCoreConfigSkeleton::~KCoreConfigSkeleton() @@ -1044,7 +1044,7 @@ KSharedConfig::Ptr KCoreConfigSkeleton::sharedConfig() const void KCoreConfigSkeleton::setSharedConfig(KSharedConfig::Ptr pConfig) { - d->mConfig = pConfig; + d->mConfig = std::move(pConfig); } KConfigSkeletonItem::List KCoreConfigSkeleton::items() const -- cgit v1.2.1